Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding ngAtlanta 2019 #27522

Closed
wants to merge 1 commit into from
Closed

docs: adding ngAtlanta 2019 #27522

wants to merge 1 commit into from

Conversation

zackarychapple
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

trotyl
trotyl reviewed Dec 7, 2018
View reviewed changes
aio/content/marketing/events.html Outdated
<tr>
<th><a href="https://ng-atl.org/" title="ngAtlanta">ngAtlanta</a></th>
<td>Atlanta, Georgia</td>
<td>January 8, 2019</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the site it says to be JAN 9 - JAN 12, 2019, should them be made consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@trotyl
Copy link
Contributor

trotyl commented Dec 7, 2018

This doesn't seem belong to aio scope (or docs-infra now) which is for the web application itself, a user-oriented doc change should have no scope:

for docs changes that are not related to a specific package (e.g. docs: fix typo in tutorial).

@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2018
@mary-poppins
Copy link

You can preview ae7fdab at https://pr27522-ae7fdab.ngbuilds.io/.
You can preview 801be82 at https://pr27522-801be82.ngbuilds.io/.

@gkalpak gkalpak added aio: preview target: patch This PR is targeted for the next patch release labels Dec 7, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 7, 2018
@gkalpak gkalpak added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2018
@zackarychapple
Copy link
Contributor Author

@trotyl good catch. I updated it.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 7, 2018
@mary-poppins
Copy link

You can preview 3991798 at https://pr27522-3991798.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 21be790 at https://pr27522-21be790.ngbuilds.io/.

gkalpak
gkalpak requested changes Dec 7, 2018
View reviewed changes
aio/content/marketing/events.html Outdated
<tr>
<th><a href="https://ng-atl.org/" title="ngAtlanta">ngAtlanta</a></th>
<td>Atlanta, Georgia</td>
<td>January 9, 2019</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put a range here (e.g. January 9-12, 2019). Otherwise, it may be interpreted as a one-day conference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

aio/content/marketing/events.html Outdated
@@ -13,6 +13,12 @@ <h1 class="banner-headline no-toc no-anchor">Events</h1>
</tr>
</thead>
<tbody>
<!-- ngAtlanta 2019-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but I couldn't help myself: Can you add a space before the closing --> 🙏 🙏 🙏 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gkalpak
Copy link
Member

gkalpak commented Dec 7, 2018

Can you also update the commit message as @trotyl suggested (e.g. docs: ...)?

@brandonroberts brandonroberts added feature Issue that requests a new feature effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR docsarea: marketing labels Dec 11, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 11, 2018
@mary-poppins
Copy link

You can preview 7c18e3c at https://pr27522-7c18e3c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9c451e5 at https://pr27522-9c451e5.ngbuilds.io/.

@gkalpak gkalpak changed the title docs(aio): adding ngAtlanta 2019 docs: adding ngAtlanta 2019 Dec 14, 2018
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Dec 14, 2018
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 14, 2018
@mhevery mhevery closed this in f9545d1 Dec 14, 2018
mhevery pushed a commit that referenced this pull request Dec 14, 2018
@zackarychapple @mhevery
docs: adding ngAtlanta 2019 (#27522)
c220328 
PR Close #27522
@zackarychapple zackarychapple deleted the ngAtlanta branch December 22, 2018 15:23
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@zackarychapple @ngfelixl
docs: adding ngAtlanta 2019 (angular#27522)
4a7cb3f 
PR Close angular#27522
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trotyl trotyl trotyl left review comments

@StephenFluin StephenFluin StephenFluin approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours feature Issue that requests a new feature risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zackarychapple @googlebot @trotyl @mary-poppins @gkalpak @StephenFluin @brandonroberts